Add new features to WasiState builder API #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for ergonomic swapping out of stdin, stdout, stderr as well as a new PreopenDir sub-builder which enables for user control over the permissions that the directory is preopened with. This PR includes breaking changes to the pubilc API.
nlewycky
reviewed
Jan 22, 2020
Co-Authored-By: nlewycky <[email protected]>
nlewycky
approved these changes
Jan 22, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 22, 2020
1170: Add new features to WasiState builder API r=MarkMcCaskey a=MarkMcCaskey Allows for ergonomic swapping out of stdin, stdout, stderr as well as a new PreopenDir sub-builder which enables for user control over the permissions that the directory is preopened with. This PR includes breaking changes to the pubilc API. TODO: - [x] Add doc examples of using the new sub-builder - [x] Discuss and maybe readd removed broken API with `deprecated` attributes on them # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for ergonomic swapping out of stdin, stdout, stderr as well as
a new PreopenDir sub-builder which enables for user control over the
permissions that the directory is preopened with.
This PR includes breaking changes to the pubilc API.
TODO:
deprecatedattributes on themReview