Add clippy error checking in lint step #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
requested review from
bjfish,
Hywan,
losfair and
nlewycky
as code owners
MarkMcCaskey
force-pushed
the
ci/clippy-error-check-in-lint
branch
from
172c9e9 to
ece1823
Compare
MarkMcCaskey
force-pushed
the
ci/clippy-error-check-in-lint
branch
from
ece1823 to
d1f0499
Compare
nlewycky
approved these changes
Jan 18, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 18, 2020
1163: Add clippy error checking in lint step r=MarkMcCaskey a=MarkMcCaskey # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
Build succeeded
|
1 task
bors bot
added a commit
that referenced
this pull request
Feb 24, 2020
1245: Revert change of Ubuntu 18.04 to 16.04 r=MarkMcCaskey a=MarkMcCaskey I didn't document why I changed it to 18.04 in #1163 ; making this PR to run CI and find out why. It looks like CI is passing! I have no idea why I updated to 18.04. Perhaps I misread [the support table](https://wiki.ubuntu.com/Releases) and thought 16.04 no longer had standard support. Either way, this PR seems good to merge. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review