Set backend_id to static str #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
requested review from
bjfish,
Hywan,
losfair,
MarkMcCaskey and
nlewycky
as code owners
Hywan
added
🎉 enhancement
| @@ -82,7 +82,7 @@ pub fn read_module< | |||
|
|
|||
| func_assoc: Map::new(), | |||
| signatures: Map::new(), | |||
| backend: MCG::backend_id(), | |||
| backend: MCG::backend_id().to_string(), | |||
There was a problem hiding this comment.
If we know that it has to be &'static str, then we can change it to be a &'static str in the structs too and remove all uses of to_string()!
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 15, 2020
1143: Set backend_id to static str r=MarkMcCaskey a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description As per feedback in #1099, set backend_id to static str. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per feedback in #1099, set backend_id to static str.
Review