fix(runtime-core) Avoid crashing when missing host functions are allowed #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
bug
MarkMcCaskey
approved these changes
Jan 9, 2020
| /// Get the underlying func pointer. | ||
| pub fn get_vm_func(&self) -> NonNull<vm::Func> { | ||
| self.func | ||
| } |
There was a problem hiding this comment.
Is this a breaking change?
There was a problem hiding this comment.
Nop. It was implemented for Func<Kind = Wasm, …> only, now it's implemented for Kind = Wasm and Kind = Host.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 10, 2020
1128: fix(runtime-core) Avoid crashing when missing host functions are allowed r=Hywan a=Hywan Fix #1118. #1121 can be merged after This PR fixes 2 things: * When droping the import backing, check that `vm::FuncCtx` isn't null before dropping it, * Use an `always_trap` as a placeholder host function when a host function is missing. Co-authored-by: Ivan Enderlin <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1118.
Address #1121.
This PR fixes 2 things:
vm::FuncCtxisn't null before dropping it,always_trapas a placeholder host function when a host function is missing.