Generic unique identifiers. #1106
Conversation
| pub const fn allocate() -> UniqueId<B> { | ||
| UniqueId { | ||
| init: Once::new(), | ||
| inner: UnsafeCell::new(::std::usize::MAX), |
There was a problem hiding this comment.
⛳ std::usize::max is fine in modern Rust; usize::max_value() is also fine (doesn't need to be qualified at all)
| pub struct UniqueId<B: UniqueIdBacking> { | ||
| /// Init once field. | ||
| init: Once, | ||
| /// Inner field. |
There was a problem hiding this comment.
While we're touching this code, can be do a bit of clean up here and explain what inner is and why it's in an UnsafeCell?
| /// A unique identifier. | ||
| pub struct UniqueId<B: UniqueIdBacking> { | ||
| /// Init once field. | ||
| init: Once, |
There was a problem hiding this comment.
I'd like to update this, too -- the doc comment doesn't say anything the source code doesn't already say
| init: Once, | ||
| /// Inner field. | ||
| inner: UnsafeCell<usize>, | ||
| _phantom: PhantomData<B>, |
There was a problem hiding this comment.
And if you have context on this part of the code, I'd appreciate a description of the phantom data and the entire thing struct in general -- if you don't understand the code then don't worry about it
|
|
||
| fn get_counter() -> &'static ::std::sync::atomic::AtomicUsize { | ||
| static COUNTER: ::std::sync::atomic::AtomicUsize = | ||
| ::std::sync::atomic::AtomicUsize::new(0); |
There was a problem hiding this comment.
We can remove the leading :: now and consider importing std::sync::atomic or at least sync so this can be sync::atomic::AtomicUsize or atomic::AtomicUsize
| @@ -0,0 +1,78 @@ | |||
| //! Unique identifiers. | |||
There was a problem hiding this comment.
I'd appreciate more of a description here too, about exactly what it is and why we'd use it. But this is the lowest priority of the doc comments I'm asking for
|
Thanks to our work in the refactor and new internal structures, this PR is no longer needed. |
This PR adds a generic unique identifier implementation that can be used for e.g. middleware
InternalFields and backend IDs.TODO: