Improve wasmer invoke function #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
commented
Dec 11, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 11, 2019
1054: Improve wasmer invoke function r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Prior to this PR, when executing wasmer, we will have this in the stdout: ```bash ➜ wasmer fib32.wasm --invoke fib 30 main() returned: [I32(832040)] ``` Note that it says `main()` returned even if the function called is `fib`. This PR fixes this and improves the messaging also for WASI invoked functions <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus Akbary <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this PR, when executing wasmer, we will have this in the stdout:
➜ wasmer fib32.wasm --invoke fib 30 main() returned: [I32(832040)]Note that it says
main()returned even if the function called isfib.This PR fixes this and improves the messaging also for WASI invoked functions
Review