When modifying the value, also update its ExtraInfo. #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a debug_assert! on python3.7 and rustpython in wapm.
MarkMcCaskey
approved these changes
Dec 2, 2019
This also was a wrong-code bug (I think), but we can't yet write tests for those.
There shouldn't be. When developing this code I've been indecisive and changed whether ExtraInfo gets propagated through functions like apply_pending_canonicalization along with the value, and that led to me auditing and re-auditing how every operator handles its ExtraInfo. I think this is a special case that I missed in my last read through the code due to Operator::Select being different from any other instructions. |
MarkMcCaskey
approved these changes
Dec 3, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 3, 2019
1034: When modifying the value, also update its ExtraInfo. r=nlewycky a=nlewycky Fixes a debug_assert! on python3.7 and rustpython in wapm. Co-authored-by: Nick Lewycky <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a debug_assert! on python3.7 and rustpython in wapm.