Add a 'clear' method to map. #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewycky
requested review from
MarkMcCaskey and
bjfish
and removed request for
bjfish and
Hywan
bjfish
approved these changes
Nov 25, 2019
nlewycky
force-pushed
the
features/map-clear
branch
from
94eca51 to
4e2440d
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 25, 2019
1017: Add a 'clear' method to map. r=nlewycky a=nlewycky # Description Motivated by work on the `nlewycky/inkwell-lifetimes` branch. No callers yet on master, but we use it on the branch and I'd like to merge in pieces. Co-authored-by: Nick Lewycky <[email protected]>
MarkMcCaskey
approved these changes
Nov 25, 2019
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivated by work on the
nlewycky/inkwell-lifetimesbranch. No callers yet on master, but we use it on the branch and I'd like to merge in pieces.