Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt backend usage depending on wasm file executed #998

Closed
syrusakbary opened this issue Nov 21, 2019 · 0 comments · Fixed by #1004
Closed

Adapt backend usage depending on wasm file executed #998

syrusakbary opened this issue Nov 21, 2019 · 0 comments · Fixed by #1004
Assignees
Labels
🎉 enhancement New feature! 📦 lib-cli About wasmer-cli

Comments

@syrusakbary
Copy link
Member

Thanks for proposing a new feature!

Motivation

When we do wasmer run xyz.wasm, we want to execute this module automatically with the singlepass backend if the file is larger than 10Mb.

Proposed solution

Wasmer right now have cranelift as the default backend in the StructOpt. We should make another option to be autodetect (to be the default) and choose the backend depending on what's available and the file size.

@syrusakbary syrusakbary added the 🎉 enhancement New feature! label Nov 21, 2019
@Hywan Hywan added the 📦 lib-cli About wasmer-cli label Nov 22, 2019
bors bot added a commit that referenced this issue Nov 25, 2019
1004: Adapt backend usage depending on wasm file executed r=Hywan a=d0iasm

Adapt backend usage depending on wasm file executed in issue #998.
Close #998 

# Description
Add `auto` backend into a runtime-core and use it as a default backend.
The `auto` backend is equivalent to: 
* singlepass if singlepass is enabled and the wasm file size is larger than 10MiB, or singlepass is enable and the target architecture is aarch64.
* cranelift otherwise.


Co-authored-by: Asami Doi <[email protected]>
Co-authored-by: Ivan Enderlin <[email protected]>
bors bot added a commit that referenced this issue Nov 25, 2019
1004: Adapt backend usage depending on wasm file executed r=Hywan a=d0iasm

Adapt backend usage depending on wasm file executed in issue #998.
Close #998 

# Description
Add `auto` backend into a runtime-core and use it as a default backend.
The `auto` backend is equivalent to: 
* singlepass if singlepass is enabled and the wasm file size is larger than 10MiB, or singlepass is enable and the target architecture is aarch64.
* cranelift otherwise.


Co-authored-by: Asami Doi <[email protected]>
Co-authored-by: Ivan Enderlin <[email protected]>
bors bot added a commit that referenced this issue Nov 27, 2019
1004: Adapt backend usage depending on wasm file executed r=d0iasm a=d0iasm

Adapt backend usage depending on wasm file executed in issue #998.
Close #998 

# Description
Add `auto` backend into a runtime-core and use it as a default backend.
The `auto` backend is equivalent to: 
* singlepass if singlepass is enabled and the wasm file size is larger than 10MiB, or singlepass is enable and the target architecture is aarch64.
* cranelift otherwise.


Co-authored-by: Asami Doi <[email protected]>
Co-authored-by: Ivan Enderlin <[email protected]>
@bors bors bot closed this as completed in 19dfdec Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! 📦 lib-cli About wasmer-cli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants