Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo test fails for runtime-c-api at least on linux #812

Closed
ethanfrey opened this issue Sep 18, 2019 · 1 comment · Fixed by #813
Closed

cargo test fails for runtime-c-api at least on linux #812

ethanfrey opened this issue Sep 18, 2019 · 1 comment · Fixed by #813
Assignees
Labels
bug Something isn't working 📦 lib-c-api About wasmer-c-api

Comments

@ethanfrey
Copy link
Contributor

Describe the bug

Discovered when I updated versions while reporting #811
This is a minor typo that at least makes my ubuntu/linux c compiler complain.

echo "`wasmer -V` | `rustc -V` | `uname -m`"
wasmer: command not found
 | rustc 1.38.0-nightly (c43d03a19 2019-08-14) | x86_64

git log -1 provides:

commit 0ea5b1b2bd87a704e2963bb92b9c0d96e2bf66ba (HEAD -> master, origin/staging, origin/master)
Merge: 174cc9f0 71b865aa
Author: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Date:   Wed Sep 18 16:59:37 2019 +0000

Steps to reproduce

git checkout master
cd lib/runtime-c-api
cargo test

Expected behavior

Actual behavior

CMakeFiles/test-exports.dir/build.make:62: recipe for target 'CMakeFiles/test-exports.dir/test-exports.c.o' failed
CMakeFiles/Makefile2:289: recipe for target 'CMakeFiles/test-exports.dir/all' failed
Makefile:94: recipe for target 'all' failed

stderr:
/home/ethan/IdeaProjects/wasmer/lib/runtime-c-api/tests/test-exports.c: In function ‘main’:
/home/ethan/IdeaProjects/wasmer/lib/runtime-c-api/tests/test-exports.c:245:28: error: format ‘%lld’ expects argument of type ‘long long int’, but argument 2 has type ‘int64_t {aka long int}’ [-Werror=format=]
         printf("Result: %lld\n", outputs[0].value.I64);
                         ~~~^     ~~~~~~~~~~~~~~~~~~~~
                         %ld
cc1: all warnings being treated as errors
make[2]: *** [CMakeFiles/test-exports.dir/test-exports.c.o] Error 1
make[1]: *** [CMakeFiles/test-exports.dir/all] Error 2
make: *** [all] Error 2

Additional context

@ethanfrey ethanfrey added the bug Something isn't working label Sep 18, 2019
@ethanfrey ethanfrey mentioned this issue Sep 18, 2019
1 task
@Hywan Hywan self-assigned this Sep 19, 2019
@Hywan Hywan added the 📦 lib-c-api About wasmer-c-api label Sep 19, 2019
@Hywan
Copy link
Contributor

Hywan commented Sep 19, 2019

Thank you for the bug report!

bors bot added a commit that referenced this issue Sep 19, 2019
813: Fix test printf typo r=Hywan a=ethanfrey

<!-- 
Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test:
https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests

-->

# Description
<!-- 
Provide details regarding the change including motivation,
links to related issues, and the context of the PR.
-->

Fixes #812 

`%lld -> %ld fixes cargo test compile error`

# Review

- [ ] Create a short description of the the change in the CHANGELOG.md file


Co-authored-by: Ethan Frey <[email protected]>
@bors bors bot closed this as completed in aa67dbe Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 lib-c-api About wasmer-c-api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants