Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format the C++, also replace one 'throw()' with 'noexcept'. #620

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

nlewycky
Copy link
Contributor

@nlewycky nlewycky commented Aug 2, 2019

No description provided.

…t the function does not throw.

Before C++17, throw() was equivalent to wrapping the function in a try {} catch
{ std::unexpected(); }. In C++17 throw() was made equivalent to noexcept and
in C++20 throw() was removed.
@nlewycky nlewycky requested a review from losfair as a code owner August 2, 2019 00:23
@nlewycky
Copy link
Contributor Author

nlewycky commented Aug 2, 2019

bors try

@nlewycky
Copy link
Contributor Author

nlewycky commented Aug 2, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 2, 2019
620: clang-format the C++, also replace one 'throw()' with 'noexcept'. r=nlewycky a=nlewycky



Co-authored-by: Nick Lewycky <[email protected]>
@bors bors bot merged commit 83aa9c6 into master Aug 2, 2019
@bors bors bot deleted the nlewycky/clang-format branch August 2, 2019 00:57
@bors
Copy link
Contributor

bors bot commented Aug 2, 2019

try

Merge conflict

@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm labels Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants