Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Emscripten imports so can be used from C-API #574

Closed
mrpre opened this issue Jul 22, 2019 · 1 comment · Fixed by #1062
Closed

Export Emscripten imports so can be used from C-API #574

mrpre opened this issue Jul 22, 2019 · 1 comment · Fixed by #1062
Labels
🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api 📦 lib-emscripten About wasmer-emscripten

Comments

@mrpre
Copy link

mrpre commented Jul 22, 2019 •
edited
Loading

Thanks for proposing a new feature!

Motivation

Command wasmer run can load wasm compiled by Emscripten but c-api interface can't.
Wasmer has already supported the Emscripten/WASI.

Proposed solution

  1. Support importing both custom functions and Emscripten/WASI functions.
  2. Keep features likecallinfo, import custom functionremain by c-api.
@mrpre mrpre added the 🎉 enhancement New feature! label Jul 22, 2019
@mrpre mrpre changed the title Any planning to support emscripten for c-api Any planning to support Emscripten/WASI for c-api Jul 24, 2019
@mrpre mrpre changed the title Any planning to support Emscripten/WASI for c-api Any planning to support importing both WASI and custom functions? Jul 25, 2019
@syrusakbary syrusakbary changed the title Any planning to support importing both WASI and custom functions? Export Emscripten imports so can be used from C-API Dec 12, 2019
@syrusakbary syrusakbary added 📦 lib-emscripten About wasmer-emscripten 📦 lib-c-api About wasmer-c-api labels Dec 12, 2019
@MeirShpilraien
Copy link

I also have this issue, I can run my program successfully with wasmer binary but not via the C-API.
I also tried to export myself the missing functions but it seems to be an issue with exporting namespaces that contains . (for example the global.Math).
Any ETA to support this?

@MeirShpilraien MeirShpilraien mentioned this issue Dec 13, 2019
Closed
@MarkMcCaskey MarkMcCaskey mentioned this issue Dec 13, 2019
Merged
4 tasks
bors bot added a commit that referenced this issue Dec 17, 2019
@bors @MarkMcCaskey @syrusakbary
Merge #1062
229b99a 
1062: Add emscripten functions and types to the C API r=syrusakbary a=MarkMcCaskey

resolves #574 

Left to do:
- [x] Add tests
- [x] Add memory set up, etc (need to break up monolithic ("run" function in wasmer_emscripten into pieces)
- [x] Add passing args, etc

# Review

- [x] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <[email protected]>
Co-authored-by: Mark McCaskey <[email protected]>
Co-authored-by: Syrus Akbary <[email protected]>
@bors bors bot closed this as completed in f9bb579 Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api 📦 lib-emscripten About wasmer-emscripten
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add emscripten functions and types to the C API wasmerio/wasmer
3 participants
@syrusakbary @mrpre @MeirShpilraien