Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi-fyi test script broken on darwin #4775

Closed
yagehu opened this issue May 31, 2024 · 0 comments · Fixed by #4776
Closed

wasi-fyi test script broken on darwin #4775

yagehu opened this issue May 31, 2024 · 0 comments · Fixed by #4776

Comments

@yagehu
Copy link
Contributor

yagehu commented May 31, 2024

Describe the bug

After a recent change, tests/wasi-fyi/test.sh is broken on darwin which uses an older version of bash.

Steps to reproduce

cd tests/wasi-fyi
./test.sh

Expected behavior

Should run the test after building.

Actual behavior

The script throws an unbound variable error for SKIP_LIST[@].

Additional context

https://stackoverflow.com/questions/48394251/why-are-empty-arrays-treated-as-unset-in-bash
yagehu added a commit to yagehu/wasmer that referenced this issue May 31, 2024
@yagehu
Fix wasi-fyi test.sh on darwin
b1bccfc 
The test script for wasi-fyi tests is broken on darwin which uses an
older version of bash.  This fix uses a [workaround][1].

fixes wasmerio#4775

[1]: https://stackoverflow.com/questions/48394251/why-are-empty-arrays-treated-as-unset-in-bash
@yagehu yagehu mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wasi-fyi test.sh on darwin yagehu/wasmer
1 participant
@yagehu