Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check for authentication before pushing packages #4767

Closed
ayys opened this issue May 31, 2024 · 0 comments · Fixed by #4769
Closed

No check for authentication before pushing packages #4767

ayys opened this issue May 31, 2024 · 0 comments · Fixed by #4769

Comments

@ayys
Copy link
Member

ayys commented May 31, 2024

wasmer package push and friends do not properly check if the user
is authenticated before trying to push a package. This can lead to
confusing errors like this one:

ᳱ wasmer deploy --registry https://registry.wasmer.io/graphql --publish-package --non-interactive --token "wap_abcd"
Loading local package (manifest path: /home/ayush/git/docs.wasmer.io/.)
✔ Correctly built package locally
error: The backend did not provide a valid signed URL to upload the package

This error is very confusing, and implies an issue with the
registry. When in fact, the issue is with the user not being logged
in because the token is incorrect.

ayys added a commit that referenced this issue May 31, 2024
this is necessary because otherwise, auth-related issues are
misinterpreted as backend failures.

closes #4767
ayys added a commit that referenced this issue May 31, 2024
this is necessary because otherwise, auth-related issues are
misinterpreted as backend failures.

closes #4767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant