Should not be able to path_open directory with rights::fd_write

[yagehu]

Describe the bug

Calling path_open on a directory with the fd_write right should fail with isdir. This behavior is consistent among other runtimes (Wasmtime, WasmEdge, Wazero, WAMR, Node). Wasmer however successfully opens the directory.

wasmer -vV; rustc -vV
wasmer 4.3.1 (b986b4a 2024-05-28)
binary: wasmer-cli
commit-hash: b986b4a0faa56a30daa3554feff29e191849da65
commit-date: 2024-05-28
host: x86_64-apple-darwin
compiler: singlepass,cranelift
rustc 1.78.0 (9b00956e5 2024-04-29)
binary: rustc
commit-hash: 9b00956e56009bab2aa15d7bff10916599e3d6d6
commit-date: 2024-04-29
host: x86_64-apple-darwin
release: 1.78.0
LLVM version: 18.1.2

Steps to reproduce

Compile this minimum example with wasi crate v0.11 (for preview1 API).

fn main() {
    unsafe {
        let fd = wasi::path_open(
            5,
            0,
            ".",
            0,
            wasi::RIGHTS_FD_READ | wasi::RIGHTS_FD_WRITE,
            0,
            0,
        )
        .unwrap();

        eprintln!("fd: {fd}");
    }
}

[maminrayej]

I tried fixing the behavior by adding this condition to path_open_internal:

if let Kind::Dir { .. } = *working_dir.inode.kind.read().unwrap() {
    if adjusted_rights.contains(Rights::FD_WRITE) {
        return Ok(Err(Errno::Isdir));
    }
}

But it breaks other things unfortunately.

cc @syrusakbary