Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert breaking change in LinearMemory trait (grow_at_least/reset) #4392

Closed
theduke opened this issue Jan 8, 2024 · 1 comment · Fixed by #4393
Closed

Revert breaking change in LinearMemory trait (grow_at_least/reset) #4392

theduke opened this issue Jan 8, 2024 · 1 comment · Fixed by #4393
Assignees
@theduke
Labels
🚨 breaking change This Issue or PR involves a breaking change bug Something isn't working 📦 lib-api About wasmer

Comments

@theduke
Copy link
Contributor

theduke commented Jan 8, 2024 •
edited
Loading

#4263 added two new methods to the LinearMemory trait. (grow_at_least, reset)

The methods do not have stub default implementations, making this a breaking change.

We need to add no-op/failing stub impls.
@linear Linear
Copy link

linear bot commented Jan 8, 2024

RUN-42 Revert breaking change in LinearMemory trait (grow_at_least/reset)

@theduke theduke added bug Something isn't working 📦 lib-api About wasmer 🚨 breaking change This Issue or PR involves a breaking change labels Jan 8, 2024
@theduke theduke self-assigned this Jan 8, 2024
theduke added a commit that referenced this issue Jan 8, 2024
@theduke
fix(api): Provide stub impls for new LinearMemory methods
f182450 
This reverts a breaking API change by providing stub implementations for
two new methods on LinearMemory (grow_at_least, reset).

The implementations return a new MemoryError::UnsupportedOperation.
Note: Since MemoryError is non-exhaustive, adding a new variant is
allowed.

We can make these methods required in a future major release if desired.

Closes #4392
@theduke theduke mentioned this issue Jan 8, 2024
Merged
theduke added a commit that referenced this issue Jan 8, 2024
@theduke
fix(api): Provide stub impls for new LinearMemory methods
ff335cb 
This reverts a breaking API change by providing stub implementations for
two new methods on LinearMemory (grow_at_least, reset).

The implementations return a new MemoryError::UnsupportedOperation.
Note: Since MemoryError is non-exhaustive, adding a new variant is
allowed.

We can make these methods required in a future major release if desired.

Closes #4392
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

Labels
🚨 breaking change This Issue or PR involves a breaking change bug Something isn't working 📦 lib-api About wasmer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): Provide stub impls for new LinearMemory methods wasmerio/wasmer
1 participant
@theduke