Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package with dependencies fails to run #3748

Closed
syrusakbary opened this issue Apr 6, 2023 · 1 comment · Fixed by #3852
Closed

Package with dependencies fails to run #3748

syrusakbary opened this issue Apr 6, 2023 · 1 comment · Fixed by #3852
Assignees
Labels
priority-medium Medium priority issue 📦 wapm About WAPM
Milestone

Comments

@syrusakbary
Copy link
Member

This:

wasmer run https://wapm.dev/wasmer/wasmer-io

Should work (the package has a dependency with commands).
But it currently fails:

error: Cannot run wasmer/[email protected]: package has no commands
@theduke
Copy link
Contributor

theduke commented Apr 10, 2023

This is currently only implemented in wasix, which will fall back to dependencies to discover the default command.

We can add that logic to the runner resolution, but we should also add an explicit syntax for defering commands to a dependency - I'm not a huge fan of the auto fallback.

@Michael-F-Bryan Michael-F-Bryan self-assigned this Apr 11, 2023
@Michael-F-Bryan Michael-F-Bryan added 📦 wapm About WAPM priority-medium Medium priority issue labels Apr 11, 2023
@Michael-F-Bryan Michael-F-Bryan added this to the v3.3 milestone Apr 11, 2023
@Michael-F-Bryan Michael-F-Bryan modified the milestones: v3.3, v4.0 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-medium Medium priority issue 📦 wapm About WAPM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants