Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework filesystem mapping and partial overlap of --mapdir directories #3492

Closed
fschutt opened this issue Jan 18, 2023 · 3 comments
Closed

Rework filesystem mapping and partial overlap of --mapdir directories #3492

fschutt opened this issue Jan 18, 2023 · 3 comments
Labels
⚙️ feature request 📦 lib-vfs About wasmer-vfs priority-medium Medium priority issue
Milestone

Comments

@fschutt
Copy link
Contributor

fschutt commented Jan 18, 2023

Currently when mapping directories in WASI with .map_dir(), the order of mapping is important, as /lib/api/blah could overwrite another mapping. Currently the order of mappings is important, but we should fix this in the next release or at least when we migrate / rework the [fs] mapping in the new Manifest format.

Also, duplicated mapping to / (root folder) aren't allowed, which makes dependency management impossible if two packages use the same folder name. (for example, having a dependency on python, which maps to / -> /usr/bin/python and a dependency on ruby mapping / -> /usr/bin/ruby). In the end /ruby.wasm and /python.wasm should both work, the only danger are conflicting file names (should be recognized and rejected when uploading).

@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 24, 2023

Related to #3476

@Michael-F-Bryan Michael-F-Bryan added 📦 lib-vfs About wasmer-vfs priority-medium Medium priority issue labels Mar 21, 2023
@Michael-F-Bryan
Copy link
Contributor

This is also related to #3678.

@Michael-F-Bryan Michael-F-Bryan modified the milestones: v3.2, v3.3 Apr 12, 2023
@ptitSeb ptitSeb modified the milestones: v3.3, v4.x Apr 20, 2023
@syrusakbary
Copy link
Member

Closing this in favor of #3678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feature request 📦 lib-vfs About wasmer-vfs priority-medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

4 participants