Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve --mapdir ergonomics / Add support for --mount #3476

Closed
fschutt opened this issue Jan 11, 2023 · 4 comments
Closed

Improve --mapdir ergonomics / Add support for --mount #3476

fschutt opened this issue Jan 11, 2023 · 4 comments
Labels
🎉 enhancement New feature! priority-medium Medium priority issue 🏚 stale Inactive issues or PR
Milestone

Comments

@fschutt
Copy link
Contributor

fschutt commented Jan 11, 2023

It's never clear which way --mapdir and [fs] sections should map: guest:host or host:guest? It would be better to enforce it either via typing or via very clearly named structs.

@ptitSeb ptitSeb added this to the v3.3 milestone Jan 17, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 17, 2023

--mapdir was here for compatibility reason (with wasmtimes).
Having a syntax like Docker or linux mount would be much simpler and unambigious.

@ptitSeb ptitSeb changed the title Proper typing for --mapdir Improve --mapdir ergonomics Jan 17, 2023
@ptitSeb ptitSeb added the priority-medium Medium priority issue label Jan 17, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 17, 2023

--mapdir will need to be still supported but marked as deprecated

@ptitSeb ptitSeb added the 🎉 enhancement New feature! label Jan 17, 2023
@syrusakbary syrusakbary changed the title Improve --mapdir ergonomics Improve --mapdir ergonomics / Add support for --mount Jan 24, 2023
@ptitSeb ptitSeb modified the milestones: v3.3, v4.0 Apr 20, 2023
@ptitSeb ptitSeb modified the milestones: v4.0, v4.x May 17, 2023
Copy link

stale bot commented May 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label May 18, 2024
Copy link

stale bot commented Jun 19, 2024

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! priority-medium Medium priority issue 🏚 stale Inactive issues or PR
Projects
None yet
Development

No branches or pull requests

2 participants