Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize running integration tests with rayon #3437

Closed
fschutt opened this issue Dec 20, 2022 · 3 comments
Closed

Parallelize running integration tests with rayon #3437

fschutt opened this issue Dec 20, 2022 · 3 comments
Labels
🎉 enhancement New feature! priority-medium Medium priority issue 🏚 stale Inactive issues or PR 🧪 tests I love tests

Comments

@fschutt
Copy link
Contributor

fschutt commented Dec 20, 2022

Right now in #3353 we are running integration tests with a single thread, which is especially slow when running the create-exe tests because of compilation. We should run these tests in parallel, however the last time I tried doing that I ran into problems with static_defs.h being written to from multiple threads (race condition on disk). We should switch to temp directories when refactoring the create-exe code, then re-enable rayon.

@fschutt fschutt added the 🎉 enhancement New feature! label Dec 20, 2022
@Michael-F-Bryan Michael-F-Bryan added the priority-medium Medium priority issue label Dec 27, 2022
@Michael-F-Bryan
Copy link
Contributor

It'll be easier to work on this after #3430 is merged.

@Michael-F-Bryan Michael-F-Bryan added the 🧪 tests I love tests label Dec 27, 2022
Copy link

stale bot commented Dec 28, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Dec 28, 2023
Copy link

stale bot commented Jan 27, 2024

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! priority-medium Medium priority issue 🏚 stale Inactive issues or PR 🧪 tests I love tests
Projects
None yet
Development

No branches or pull requests

2 participants