Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rust toolchain issues in Build process, Github Actions #3055

Closed
epilys opened this issue Aug 1, 2022 · 2 comments
Closed

Fix rust toolchain issues in Build process, Github Actions #3055

epilys opened this issue Aug 1, 2022 · 2 comments
Assignees
@silwol
Labels
bug Something isn't working priority-high High priority issue

Comments

@epilys
Copy link
Contributor

epilys commented Aug 1, 2022

After github actions were recently upgraded to change rust toolchains, some of the builds in build.sys stopped completely working.
@epilys epilys added bug Something isn't working priority-high High priority issue labels Aug 1, 2022
@silwol
Copy link
Contributor

silwol commented Aug 2, 2022 •
edited
Loading

There are two distinct issues at play here:

  • macos-arm64 build fails because we attempt to reset the rustup override with rustup override set stable at the end of the Build Minimal Wasmer Headless step, but in this case we should do that with rustup override unset in order to avoid side effects
  • linux-musl-x64 is built on the alpine docker container, and apparently ~ is set by dtolnay/rust-toolchain but is is not correctly read from the $PATH environment variable. This needs to be fixed upstream, replacing ~ with $HOME when adding to GITHUB_PATH.

@silwol silwol mentioned this issue Aug 2, 2022
Merged
silwol added a commit that referenced this issue Aug 2, 2022
@silwol
CI: Unset rustup override after usage instead of setting it to stable
6d196d8 
Fixes the `macos-arm64` error from #3055
silwol added a commit that referenced this issue Aug 2, 2022
@silwol
CI: Unset rustup override after usage instead of setting it to stable
8fc7815 
Fixes the `macos-arm64` error from #3055
@silwol silwol mentioned this issue Aug 2, 2022
Merged
bors bot added a commit that referenced this issue Aug 2, 2022
@bors @silwol
Merge #3060
6f43bed 
3060: CI: Unset rustup override after usage instead of setting it to stable r=silwol a=silwol

Fixes the `macos-arm64` error from #3055

Co-authored-by: Wolfgang Silbermayr <[email protected]>
@silwol
Copy link
Contributor

silwol commented Aug 2, 2022

Closed by #3060 and dtolnay/rust-toolchain#28

@silwol silwol closed this as completed Aug 2, 2022
ptitSeb pushed a commit that referenced this issue Oct 20, 2022
@silwol @ptitSeb
CI: Unset rustup override after usage instead of setting it to stable
a29d3d0 
Fixes the `macos-arm64` error from #3055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silwol silwol

Labels
bug Something isn't working priority-high High priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silwol @epilys