Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test wast::spec::unreachable::cranelift::universal fails on aarch64-apple-darwin target #2847

Closed
epilys opened this issue Apr 15, 2022 · 2 comments
Assignees
Labels
bug Something isn't working priority-high High priority issue

Comments

@epilys
Copy link
Contributor

epilys commented Apr 15, 2022

Describe the bug

Starting from commit 4c94625, test wast::spec::unreachable::cranelift::universal fails on M1 macos:

$ echo "`rustc -V` | `uname -rm`"
rustc 1.59.0 (9d1b2106e 2022-02-23) | 21.4.0 arm64
running 1 test                                                                                                                                                        
test wast::spec::unreachable::cranelift::universal ... FAILED                                                                                                         
                                                                                                                                                                      
failures:                                                                                                                                                             
                                                                                                                                                                      
---- wast::spec::unreachable::cranelift::universal stdout ----                                                                                                        
Running wast `tests/wast/spec/unreachable.wast`                                    
Error: Failed directives on tests/wast/spec/unreachable.wast:                      
  • expected 'unreachable', got 'RuntimeError: call stack exhausted' (231:1)       
                                                                                                                                                                      
thread 'wast::spec::unreachable::cranelift::universal' panicked at 'assertion failed: `(left == right)`                                                               
  left: `1`,                                                                                                                                                          
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library
/test/src/lib.rs:186:5                                                             
stack backtrace:                                                                   
   0: rust_begin_unwind                                                                                                                                               
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/std/src/panicking.rs:498:5                                                                    
   1: core::panicking::panic_fmt                                                                                                                                      
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:116:14                                                                  
   2: core::panicking::assert_failed_inner                                                                                                                            
   3: core::panicking::assert_failed                                                                                                                                  
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/panicking.rs:154:5
   4: test::assert_test_result                                                     
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/test/src/lib.rs:186:5                                                                         
   5: compilers::wast::spec::unreachable::cranelift::universal::{{closure}}        
             at ./target/aarch64-apple-darwin/debug/build/wasmer-workspace-eb89d2cca1826d47/out/generated_spectests.rs:407:5
   6: core::ops::function::FnOnce::call_once                                  
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/ops/function.rs:227:5
   7: core::ops::function::FnOnce::call_once                                                                                                                          
             at /rustc/9d1b2106e23b1abd32fce1f17267604a5102f57a/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace
@epilys epilys added the bug Something isn't working label Apr 15, 2022
@Amanieu Amanieu assigned ptitSeb and unassigned Amanieu Apr 20, 2022
@Amanieu
Copy link
Contributor

Amanieu commented Apr 20, 2022

I don't have access to an aarch64 mac to test this.

@heyjdp heyjdp added the priority-high High priority issue label Apr 27, 2022
@ptitSeb
Copy link
Contributor

ptitSeb commented Aug 3, 2022

Fixed with #3058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-high High priority issue
Projects
None yet
Development

No branches or pull requests

4 participants