Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loupe dependency optional #2744

Closed
syrusakbary opened this issue Jan 5, 2022 · 0 comments
Closed

Make loupe dependency optional #2744

syrusakbary opened this issue Jan 5, 2022 · 0 comments
Assignees
@Amanieu
Labels
🎉 enhancement New feature! priority-low Low priority issue
Milestone
v2.x

Comments

@syrusakbary
Copy link
Member

We should make loupe dependency optional based on a feature, following up from this comment: #2735 (comment)
@syrusakbary syrusakbary added the 🎉 enhancement New feature! label Jan 5, 2022
@syrusakbary syrusakbary added this to the v2.x milestone Jan 5, 2022
@syrusakbary syrusakbary mentioned this issue Jan 5, 2022
Closed
@Amanieu Amanieu added the priority-low Low priority issue label Feb 9, 2022
epilys added a commit that referenced this issue May 4, 2022
@epilys
Remove loupe dependency
30a09a0 
Closes #2731
Closes #2744
@epilys epilys mentioned this issue May 4, 2022
Merged
epilys added a commit that referenced this issue May 4, 2022
@epilys
Remove loupe dependency
6893fa1 
Closes #2731
Closes #2744
epilys added a commit that referenced this issue May 4, 2022
@epilys
Remove loupe dependency
dd6cb2c 
Closes #2731
Closes #2744
@epilys epilys closed this as completed May 4, 2022
Amanieu pushed a commit that referenced this issue May 9, 2022
@epilys @Amanieu
Remove loupe dependency
a0418ca 
Closes #2731
Closes #2744
epilys added a commit that referenced this issue Jun 6, 2022
@epilys
Remove loupe dependency
45c68e9 
Closes #2731
Closes #2744
epilys added a commit that referenced this issue Jun 8, 2022
@epilys
Remove loupe dependency
00f9a3c 
Closes #2731
Closes #2744
ptitSeb pushed a commit that referenced this issue Oct 20, 2022
@epilys @ptitSeb
Remove loupe dependency
f8848eb 
Closes #2731
Closes #2744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amanieu Amanieu

Labels
🎉 enhancement New feature! priority-low Low priority issue
Projects
None yet
Milestone
v2.x
Development

No branches or pull requests
3 participants
@syrusakbary @Amanieu @epilys