Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack overflow since version 1.0.0-alpha3 #1674

Closed
kateinoigakukun opened this issue Oct 3, 2020 · 2 comments · Fixed by #1671
Closed

Stack overflow since version 1.0.0-alpha3 #1674

kateinoigakukun opened this issue Oct 3, 2020 · 2 comments · Fixed by #1671
Assignees
@nlewycky
Labels
bug Something isn't working

Comments

@kateinoigakukun
Copy link
Contributor

Describe the bug

Binary: https://gist.github.com/kateinoigakukun/bb62851920f5935d6f23fc9a88fff022

This wasm binary can't be run with wasmer 1.0.0-alpha3 with cranelift backend.

wasmer 1.0.0-alpha3 | rustc 1.42.0-nightly (0de96d37f 2019-12-19) | x86_64

Steps to reproduce

$ wget https://gist.github.com/kateinoigakukun/bb62851920f5935d6f23fc9a88fff022/raw/cb41560e14dfa7f05ff49fb20f1ac6c1c1013d5e/a.out
$ wasmer run a.out --llvm
[ RUN      ] NumericParsing.UInt8/success
[       OK ] NumericParsing.UInt8/success
[ RUN      ] NumericParsing.Int8/success
[       OK ] NumericParsing.Int8/success
[ RUN      ] NumericParsing.UInt16/success
[       OK ] NumericParsing.UInt16/success
[ RUN      ] NumericParsing.Int16/success
[       OK ] NumericParsing.Int16/success
[ RUN      ] NumericParsing.UInt32/success
[       OK ] NumericParsing.UInt32/success
[ RUN      ] NumericParsing.Int32/success
[       OK ] NumericParsing.Int32/success
[ RUN      ] NumericParsing.UInt64/success
[       OK ] NumericParsing.UInt64/success
[ RUN      ] NumericParsing.Int64/success
[       OK ] NumericParsing.Int64/success
[ RUN      ] NumericParsing.UInt/success
[       OK ] NumericParsing.UInt/success
[ RUN      ] NumericParsing.Int/success
[       OK ] NumericParsing.Int/success
[ RUN      ] NumericParsing.FixedWidthInteger/maxUInt64
[       OK ] NumericParsing.FixedWidthInteger/maxUInt64
[ RUN      ] NumericParsing.Float/Basics
[       OK ] NumericParsing.Float/Basics
[ RUN      ] NumericParsing.Double/Basics
[       OK ] NumericParsing.Double/Basics
NumericParsing: All tests passed
$ wasmer run a.out --singlepass
# Same output as llvm backend
$ wasmer run a.out --cranelift
[ RUN      ] NumericParsing.UInt8/success

thread 'main' has overflowed its stack
fatal runtime error: stack overflow

Expected behavior

No stack overflow exception

Actual behavior

Additional context
@kateinoigakukun kateinoigakukun added the bug Something isn't working label Oct 3, 2020
@kateinoigakukun kateinoigakukun mentioned this issue Oct 3, 2020
Merged
kateinoigakukun added a commit to swiftwasm/swift that referenced this issue Oct 3, 2020
@kateinoigakukun
[WASM] Re-enable all stdlib tests on Linux
81496a1 
The wasmer cranelift backend is broken since 1.0.0-alpha3, so we use
singlepass backend instead until the bug will be resolved.

wasmerio/wasmer#1674
@nlewycky nlewycky self-assigned this Oct 3, 2020
@nlewycky
Copy link
Contributor

nlewycky commented Oct 3, 2020

This was just fixed in #1671! We haven't had a release with it yet.

@nlewycky nlewycky linked a pull request Oct 3, 2020 that will close this issue
Stack probes are not ordinary functions. #1671
Merged
1 task
@kateinoigakukun
Copy link
Contributor Author

Thank you for letting me know 😄 I'm looking forward to the next release.

MaxDesiatov pushed a commit to swiftwasm/swift that referenced this issue Oct 5, 2020
@kateinoigakukun @MaxDesiatov
[WASM] Re-enable all stdlib tests on Linux
fb77480 
The wasmer cranelift backend is broken since 1.0.0-alpha3, so we use
singlepass backend instead until the bug will be resolved.

wasmerio/wasmer#1674

# Conflicts:
#	test/lit.cfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlewycky nlewycky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stack probes are not ordinary functions. wasmerio/wasmer
2 participants
@nlewycky @kateinoigakukun