Skip to content

Commit

Permalink
The run-unstable tests were using the wrong --registry
Browse files Browse the repository at this point in the history
  • Loading branch information
Michael-F-Bryan committed May 19, 2023
1 parent 3083168 commit fff6df5
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion lib/wasi/src/runtime/resolver/in_memory_source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ impl InMemorySource {
Ok(source)
}

/// Add a new [`Summary`] to the [`InMemorySource`].
/// Add a new [`PackageSummary`] to the [`InMemorySource`].
pub fn add(&mut self, summary: PackageSummary) {
let summaries = self.packages.entry(summary.pkg.name.clone()).or_default();
summaries.push(summary);
Expand Down
2 changes: 1 addition & 1 deletion lib/wasi/src/runtime/resolver/registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use crate::runtime::resolver::{PackageSpecifier, PackageSummary};
pub trait Registry: Send + Sync + Debug {
async fn query(&self, pkg: &PackageSpecifier) -> Result<Vec<PackageSummary>, Error>;

/// Run [`Registry::query()`] and get the [`Summary`] for the latest
/// Run [`Registry::query()`] and get the [`PackageSummary`] for the latest
/// version.
async fn latest(&self, pkg: &PackageSpecifier) -> Result<PackageSummary, Error> {
let candidates = self.query(pkg).await?;
Expand Down
4 changes: 2 additions & 2 deletions lib/wasi/src/runtime/resolver/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ use crate::runtime::resolver::{

use super::FileSystemMapping;

/// Given the [`Summary`] for a root package, resolve its dependency graph and
/// figure out how it could be executed.
/// Given the [`PackageInfo`] for a root package, resolve its dependency graph
/// and figure out how it could be executed.
#[tracing::instrument(level = "debug", skip_all)]
pub async fn resolve(
root_id: &PackageId,
Expand Down
4 changes: 2 additions & 2 deletions lib/wasi/src/runtime/resolver/source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ pub trait Source: Debug {
///
/// A [`Registry`][reg] will typically have a list of [`Source`]s that are
/// queried in order. The first [`Source`] to return one or more
/// [`Summaries`][Summary] will be treated as the canonical source for
/// that [`Dependency`][dep] and no further [`Source`]s will be queried.
/// [`Summaries`][PackageSummary] will be treated as the canonical source
/// for that [`Dependency`][dep] and no further [`Source`]s will be queried.
///
/// [dep]: crate::runtime::resolver::Dependency
/// [reg]: crate::runtime::resolver::Registry
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/cli/tests/run_unstable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ mod remote_webc {
let assert = wasmer_run_unstable()
.arg("saghul/quickjs")
.arg("--entrypoint=quickjs")
.arg("--registry=https://wapm.io/")
.arg("--registry=wapm.io")
.arg("--")
.arg("--eval")
.arg("console.log('Hello, World!')")
Expand Down Expand Up @@ -369,7 +369,7 @@ mod remote_webc {
.arg("sharrattj/bash")
.arg("--entrypoint=bash")
.arg("--use=sharrattj/coreutils")
.arg("--registry=https://wapm.io/")
.arg("--registry=wapm.io")
.arg("--")
.arg("-c")
.arg("ls /bin")
Expand Down

0 comments on commit fff6df5

Please sign in to comment.