Skip to content

Commit

Permalink
fix(c-api) Fix how wasm_functype_t is implemented.
Browse files Browse the repository at this point in the history
In `wasm.h`, `wasm_functype_t` is implemented with
`WASM_DECLARE_TYPE`, so with `WASM_DECLARE_VEC(functype, *)`. This `*`
means the C struct for the vector is defined:

```c
struct wasm_functype_vec_t {
    size_t size;
    wasm_functype_t** data;
}
```

The way we implement `wasm_functype_vec_t` in Rust is with the
`wasm_declare_vec!` macro. And it is wrong. We must use
`wasm_declared_boxed_vec!`.
  • Loading branch information
Hywan committed Dec 17, 2020
1 parent a4effaa commit e10ad51
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/c-api/src/wasm_c_api/types/function.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ impl wasm_functype_t {
}
}

wasm_declare_vec!(functype);
wasm_declare_boxed_vec!(functype);

#[no_mangle]
pub unsafe extern "C" fn wasm_functype_new(
Expand Down

0 comments on commit e10ad51

Please sign in to comment.