Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
790: Switch llvm-backend from PIC+Default (small) to Static+Large. r=nlewycky a=nlewycky # Description Should fix flaky test failure: ``` spectest-a277b7d051ac0dde: /home/nick/llvm-8.0.1.src/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:304: void llvm::RuntimeDyldELF::resolveX86_64Relocation(const llvm::SectionEntry&, uint64_t, uint64_t, uint32_t, int64_t, uint64_t): Assertion `isInt<32>(RealOffset)' failed. ``` (with assertions-enabled LLVM). The relocation in question is a `R_X86_64_PC32` with small offset against `.rodata`. The switch from Default (small, JITDefault is a different default that we weren't using which is medium) to Large should fix the bug. Once we're using large code model, I think we can switch from PIC to static as either an optimization or a no-op. # Review - [x] Create a short description of the the change in the CHANGELOG.md file Co-authored-by: Nick Lewycky <[email protected]>
- Loading branch information