Merge #3088

3088: Fixed an issue when renaming a file from a preopened dir directly (for 3084) r=ptitSeb a=ptitSeb # Description Fixed an issue that could happens when renaming a file from a reopened folder Fix #3084 Co-authored-by: ptitSeb <[email protected]>
wasmerio · Aug 10, 2022 · b3c3df0 · b3c3df0
2 parents f0ed34c + 05dd3b7
commit b3c3df0
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/wasi/src/syscalls/mod.rs b/lib/wasi/src/syscalls/mod.rs
@@ -2649,6 +2649,13 @@ pub fn path_rename<M: MemorySize>(
         }
     }
 
+    // this is to be sure the source file is fetch from filesystem if needed
+    wasi_try!(state.fs.get_inode_at_path(
+        inodes.deref_mut(),
+        old_fd,
+        source_path.to_str().as_ref().unwrap(),
+        true
+    ));
     let (source_parent_inode, source_entry_name) =
         wasi_try!(state
             .fs
@@ -2657,7 +2664,6 @@ pub fn path_rename<M: MemorySize>(
         wasi_try!(state
             .fs
             .get_parent_inode_at_path(inodes.deref_mut(), new_fd, target_path, true));
-
     let host_adjusted_target_path = {
         let guard = inodes.arena[target_parent_inode].read();
         let deref = guard.deref();