Merge #2036

2036: Use Box<[Type]>` inside of `FunctionType` r=MarkMcCaskey a=MarkMcCaskey This saves 16 bytes (on 64bit systems) on the stack for each `FunctionType` and additional space on the heap by not allowing resizing (like Vec does) There are ways to save even more memory here but they're all heavier weight than this simple change. Co-authored-by: Mark McCaskey <[email protected]>
wasmerio · Jan 21, 2021 · aa9329b · aa9329b
2 parents e8344c5 + b597a6b
commit aa9329b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/wasmer-types/src/types.rs b/lib/wasmer-types/src/types.rs
@@ -229,9 +229,9 @@ impl ExternType {
 #[cfg_attr(feature = "enable-serde", derive(Serialize, Deserialize))]
 pub struct FunctionType {
     /// The parameters of the function
-    params: Vec<Type>,
+    params: Box<[Type]>,
     /// The return values of the function
-    results: Vec<Type>,
+    results: Box<[Type]>,
 }
 
 impl FunctionType {
@@ -242,8 +242,8 @@ impl FunctionType {
         Returns: Into<Vec<Type>>,
     {
         Self {
-            params: params.into(),
-            results: returns.into(),
+            params: params.into().into_boxed_slice(),
+            results: returns.into().into_boxed_slice(),
         }
     }