Make sure we set the "maximum" parameter when creating shared memories

wasmerio · Oct 2, 2023 · a4c286e · a4c286e
1 parent 4b38f69
commit a4c286e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/wasix/src/runtime/task_manager/mod.rs b/lib/wasix/src/runtime/task_manager/mod.rs
@@ -120,6 +120,11 @@ pub trait VirtualTaskManager: std::fmt::Debug + Send + Sync + 'static {
         match spawn_type {
             SpawnMemoryType::CreateMemoryOfType(mut ty) => {
                 ty.shared = true;
+
+                // Note: If memory is shared, maximum needs to be set in the
+                // browser otherwise creation will fail.
+                let _ = ty.maximum.get_or_insert(wasmer_types::Pages::max_value());
+
                 let mem = Memory::new(&mut store, ty).map_err(|err| {
                     tracing::error!(
                         error = &err as &dyn std::error::Error,