Merge #2957

2957: Enable multi-value handling in Singlepass compiler r=ptitSeb a=ptitSeb # Description Enabled multi-value on singlepass, as it's working (testedon linux/a86_64, macos/arm64, linux/arm64 and windows/x86_64) Co-authored-by: ptitSeb <[email protected]>
wasmerio · Jun 16, 2022 · a3daf3d · a3daf3d
2 parents 02b6989 + bdad529
commit a3daf3d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/lib/compiler-singlepass/src/compiler.rs b/lib/compiler-singlepass/src/compiler.rs
@@ -90,9 +90,6 @@ impl Compiler for SinglepassCompiler {
             }
             _ => None,
         };
-        if compile_info.features.multi_value {
-            return Err(CompileError::UnsupportedFeature("multivalue".to_string()));
-        }
         let calling_convention = match target.triple().default_calling_convention() {
             Ok(CallingConvention::WindowsFastcall) => CallingConvention::WindowsFastcall,
             Ok(CallingConvention::SystemV) => CallingConvention::SystemV,

diff --git a/tests/ignores.txt b/tests/ignores.txt
@@ -1,5 +1,4 @@
 # Compilers
-singlepass spec::multi_value # Singlepass has not implemented multivalue (functions that returns "structs"/"tuples")
 singlepass spec::simd # Singlepass doesn't support yet SIMD (no one asked for this feature)
 
 # Traps
@@ -23,8 +22,6 @@ singlepass+aarch64+macos traps::start_trap_pretty
 llvm       traps::start_trap_pretty
 cranelift+aarch64    traps::start_trap_pretty
 
-singlepass multi_value_imports::dynamic # Singlepass doesn't support multivalue
-
 # Also neither LLVM nor Cranelift currently implement stack probing on AArch64.
 # https://github.com/wasmerio/wasmer/issues/2808
 cranelift+aarch64 spec::skip_stack_guard_page