Deprecate to_wasm_error

CHANGELOG.md

@@ -16,6 +16,7 @@
 * [#1941](https://github.com/wasmerio/wasmer/pull/1941) Turn `get_remaining_points`/`set_remaining_points` of the `Metering` middleware into free functions to allow using them in an ahead-of-time compilation setup
 * [#1955](https://github.com/wasmerio/wasmer/pull/1955) Set `jit` as a default feature of the `wasmer-wasm-c-api` crate
 * [#1944](https://github.com/wasmerio/wasmer/pull/1944) Require `WasmerEnv` to be `Send + Sync` even in dynamic functions.
+* [#1963](https://github.com/wasmerio/wasmer/pull/1963) Deprecated `to_wasm_error` in favour of `impl From<BinaryReaderError> for WasmError`
 
 ### Fixed
 

lib/compiler/src/lib.rs

@@ -83,11 +83,15 @@ pub use crate::target::{
     Architecture, BinaryFormat, CallingConvention, CpuFeature, Endianness, OperatingSystem,
     PointerWidth, Target, Triple,
 };
+
+#[cfg(feature = "translator")]
+#[allow(deprecated)]
+pub use crate::translator::to_wasm_error;
 #[cfg(feature = "translator")]
 pub use crate::translator::{
-    to_wasm_error, translate_module, wptype_to_type, FunctionBodyData, FunctionMiddleware,
-    MiddlewareBinaryReader, MiddlewareReaderState, ModuleEnvironment, ModuleInfoTranslation,
-    ModuleMiddleware, ModuleMiddlewareChain, ModuleTranslationState,
+    translate_module, wptype_to_type, FunctionBodyData, FunctionMiddleware, MiddlewareBinaryReader,
+    MiddlewareReaderState, ModuleEnvironment, ModuleInfoTranslation, ModuleMiddleware,
+    ModuleMiddlewareChain, ModuleTranslationState,
 };
 pub use crate::trap::TrapInformation;
 pub use crate::unwind::CompiledFunctionUnwindInfo;

lib/compiler/src/translator/error.rs

@@ -8,10 +8,17 @@ macro_rules! wasm_unsupported {
     ($($arg:tt)*) => { $crate::WasmError::Unsupported(format!($($arg)*)) }
 }
 
+impl From<BinaryReaderError> for WasmError {
+    fn from(original: BinaryReaderError) -> Self {
+        Self::InvalidWebAssembly {
+            message: original.message().into(),
+            offset: original.offset(),
+        }
+    }
+}
+
 /// Converts a Wasm binary reading error to a runtime Wasm error
+#[deprecated(since = "1.0.0-beta3", note = "Use WasmError::from")]
 pub fn to_wasm_error(e: BinaryReaderError) -> WasmError {
-    WasmError::InvalidWebAssembly {
-        message: e.message().into(),
-        offset: e.offset(),
-    }
+    e.into()
 }

lib/compiler/src/translator/mod.rs

@@ -14,6 +14,7 @@ mod error;
 mod sections;
 
 pub use self::environ::{FunctionBodyData, ModuleEnvironment, ModuleInfoTranslation};
+#[allow(deprecated)]
 pub use self::error::to_wasm_error;
 pub use self::middleware::{
     FunctionMiddleware, MiddlewareBinaryReader, MiddlewareReaderState, ModuleMiddleware,