Skip to content

Commit

Permalink
fix(c-api) Fix how wasm_frame_t is implemented.
Browse files Browse the repository at this point in the history
In `wasm.h`, `wasm_frame_t` is implemented with `WASM_DECLARE_TYPE`,
so with `WASM_DECLARE_VEC(frame, *)`. This `*` means the C struct for
the vector is defined:

```c
struct wasm_frame_vec_t {
    size_t size;
    wasm_frame_t** data;
}
```

The way we implement `wasm_frame_vec_t` in Rust is with the
`wasm_declare_vec!` macro. And it is wrong. We must use
`wasm_declared_boxed_vec!`.
  • Loading branch information
Hywan committed Dec 17, 2020
1 parent a0c34fe commit 4abf6f8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/c-api/src/wasm_c_api/types/frame.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ pub unsafe extern "C" fn wasm_frame_module_offset(frame: &wasm_frame_t) -> usize
frame.info.module_offset()
}

wasm_declare_vec!(frame);
wasm_declare_boxed_vec!(frame);

0 comments on commit 4abf6f8

Please sign in to comment.