Merge pull request #4720 from wasmerio/revert-existing-directory-fix

Revert "make path_create_directory return error if no dir was created"
wasmerio · May 20, 2024 · 22c2415 · 22c2415
2 parents f8d29ec + e711829
commit 22c2415
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/lib/wasix/src/syscalls/wasi/path_create_directory.rs b/lib/wasix/src/syscalls/wasi/path_create_directory.rs
@@ -84,7 +84,6 @@ pub(crate) fn path_create_directory_internal(
         return Err(Errno::Inval);
     }
 
-    let mut created_dir = false;
     let mut cur_dir_inode = working_dir.inode;
     for comp in &path_vec {
         let processing_cur_dir_inode = cur_dir_inode.clone();
@@ -126,7 +125,6 @@ pub(crate) fn path_create_directory_internal(
                             return Err(Errno::Notdir);
                         }
                     } else {
-                        created_dir = true;
                         state.fs_create_dir(&adjusted_path)?;
                     }
                     let kind = Kind::Dir {
@@ -162,9 +160,5 @@ pub(crate) fn path_create_directory_internal(
         }
     }
 
-    if created_dir {
-        Ok(())
-    } else {
-        Err(Errno::Exist)
-    }
+    Ok(())
 }
diff --git a/tests/wasi-fyi/test.sh b/tests/wasi-fyi/test.sh
@@ -6,7 +6,7 @@ bash build.sh
 status=0
 
 # Define skip list as an array
-SKIP_LIST=()
+SKIP_LIST=("fs_create_dir-existing-directory.wasm")
 
 # List and process .foo files
 for file in *.wasm; do