-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasi) Implement WASI #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubianchi
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good, only one minor suggestion.
bors try |
tryBuild failed: |
`wasm_instance_new` owns the `imports: wasm_extern_vec_t` array. No need to free it manually on the Go side.
bors try |
Co-authored-by: Julien BIANCHI <[email protected]>
tryBuild failed: |
On Linux aarch64, we get this error: > runtime.SetFinalizer: pointer not in allocated block This patch should fix that.
bors try |
tryBuild succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #171
Close #72
Close #128
Depend on wasmerio/wasmer#2053 (merged)
Depend on wasmerio/wasmer#2058 (merged)
Depend on wasmerio/wasmer#2059 (merged)
Depend on wasmerio/wasmer#2070 (merged)
Work in Progress. It includes the
darwin/aarch64
branch. Will be rebased onmaster
without that before merging of course.