Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewInstanceWithImports does not return helpful error when there is a mismatch #41

Closed
fproulx-dfuse opened this issue Jun 11, 2019 · 1 comment · Fixed by #42
Closed

NewInstanceWithImports does not return helpful error when there is a mismatch #41

fproulx-dfuse opened this issue Jun 11, 2019 · 1 comment · Fixed by #42
Assignees
@Hywan
Labels
📦 component-extension About the Go extension 🎉 enhancement New feature or request

Comments

@fproulx-dfuse
Copy link

NewInstanceWithImports calls out to cWasmerInstantiate and that only returns a simple error.

Motivation

To determine which imports are expected we should get better error feedback.

Proposed solution

Return more extensive error details with list of missing imports.
@fproulx-dfuse fproulx-dfuse added the 🎉 enhancement New feature or request label Jun 11, 2019
@Hywan Hywan mentioned this issue Jun 12, 2019
Merged
@Hywan Hywan self-assigned this Jun 12, 2019
@Hywan Hywan added the 📦 component-extension About the Go extension label Jun 12, 2019
bors bot added a commit that referenced this issue Jun 12, 2019
@bors @Hywan
Merge #42
722faa9 
42: feat(instance,module) Improve error messages r=Hywan a=Hywan

Fix #41.

These patches improve error messages when instantiating a module with `Module.Instantiate` or with `NewInstance`.

The error message that is returned by `Module.Instantiate` isn't very helpful, but it's going to change with wasmerio/wasmer#493. Let's wait the next release of the runtime!

Co-authored-by: Ivan Enderlin <[email protected]>
@Hywan
Copy link
Contributor

Hywan commented Jun 12, 2019

You're right! #42 addresses your request, thanks for the proposal!

@bors bors bot closed this as completed in #42 Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hywan Hywan

Labels
📦 component-extension About the Go extension 🎉 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(instance,module) Improve error messages Hywan/go-ext-wasm
2 participants
@Hywan @fproulx-dfuse