Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close gap with CLI #17

Closed
tiborvass opened this issue May 29, 2019 · 2 comments
Closed

Close gap with CLI #17

tiborvass opened this issue May 29, 2019 · 2 comments
Assignees
@Hywan
Labels
📦 component-extension About the Go extension 📦 component-runtime About the Wasm runtime 🎉 enhancement New feature or request

Comments

@tiborvass
Copy link

This may be a meta issue, it's not specific to the Go bindings (feel free to close/move the issue), but I'm opening it here since I'd be using the Go bindings.

Motivation

Users expect to be able to do the same things from the Go code than from the wasmer CLI.
Very concretely I need --mapdir and --env (wasmerio/wasmer#475).

Proposed solution

Tediously implement all new CLI features in all the bindings.

Alternatives

Generate an Options struct that would be passed as a parameter to a NewInstance() constructor. The struct could be generated from a simple struct definition in the wasmer repo.
@tiborvass tiborvass added the 🎉 enhancement New feature or request label May 29, 2019
@Hywan Hywan self-assigned this Jun 3, 2019
@Hywan Hywan added 📦 component-extension About the Go extension 📦 component-runtime About the Wasm runtime labels Jun 3, 2019
@Hywan
Copy link
Contributor

Hywan commented Jun 3, 2019

Thanks for the proposal. I'm not sure we can reflect all the wasmer CLI options with the current C/C++ bindings, but it's totally achievable.

Let's keep this issue open and let's address one feature at a time!

@Hywan Hywan mentioned this issue Jun 3, 2019
Merged
bors bot added a commit that referenced this issue Jun 3, 2019
@bors @Hywan
Merge #24
1b8bfc0 
24: feat(go-wasmer) New package to get CLI support r=Hywan a=Hywan

Partially address #17.

1. `go install github.com/wasmerio/go-ext-wasm/go-wasmer`
2. `go-wasmer call nbody.wasm main 10`

Co-authored-by: Ivan Enderlin <[email protected]>
@Hywan
Copy link
Contributor

Hywan commented Feb 4, 2021

The CLI has been removed as we prefer to keep wasmer-go as a library. Closing this issue :-).

@Hywan Hywan closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hywan Hywan

Labels
📦 component-extension About the Go extension 📦 component-runtime About the Wasm runtime 🎉 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiborvass @Hywan