Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to always generate types, regardless of whether they are used #20

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Add an option to always generate types, regardless of whether they are used #20

merged 1 commit into from
Nov 29, 2022

Conversation

Michael-F-Bryan
Copy link
Contributor

This supercedes commit fbea20f from #19.

We originally needed to add this with wasmerio/wasmer@fbdec22 because some WASI types weren't being generated if our WASI functions didn't use them.

Add an option to always generate types, regardless of whether they ar…
2d1d8c8 
…e used

See also #19 and commit fbea20f.

This was originally added around wasmerio/wasme@fbdec22bfc493849e9d194afe7999764f74d3f7e.
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Nov 29, 2022
Closed
@fschutt fschutt marked this pull request as ready for review November 29, 2022 13:38
@fschutt fschutt merged commit e8f71ad into main Nov 29, 2022
@fschutt fschutt deleted the force-generate-structs-v2 branch November 29, 2022 13:39
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Nov 29, 2022
Closed
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschutt fschutt fschutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-F-Bryan @fschutt