fix(loupe-derive) Handle struct/enum with inlined generics. #14

Hywan · 2021-03-23T11:13:36Z

struct S<T: U> {}

was incorrectly handled, as the generated code looked like:

impl<T: U> MemoryUsage for S<T: U> {}

rather than:

impl<T: U> MemoryUsage for S<T> {}

This patch fixes that.

```rs struct S<T: U> {} ``` was incorrectly handled, as the generated code looked like: ```rs impl<T: U> MemoryUsage for S<T: U> {} ``` rather than: ```rs impl<T: U> MemoryUsage for S<T> {} ``` This patch fixes that.

Hywan added 2 commits March 23, 2021 12:11

fix(loupe-derive) Handle struct/enum with inlined generics.

71955ca

```rs struct S<T: U> {} ``` was incorrectly handled, as the generated code looked like: ```rs impl<T: U> MemoryUsage for S<T: U> {} ``` rather than: ```rs impl<T: U> MemoryUsage for S<T> {} ``` This patch fixes that.

test: Ensure that all forms of generics are correctly implemented.

8fa6204

Hywan added the bug Something isn't working label Mar 23, 2021

Hywan self-assigned this Mar 23, 2021

Hywan mentioned this pull request Mar 23, 2021

feat: Implement MemoryUsage for Store wasmerio/wasmer#2199

Merged

1 task

syrusakbary approved these changes Mar 23, 2021

View reviewed changes

Hywan merged commit 8fa6204 into wasmerio:master Mar 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(loupe-derive) Handle struct/enum with inlined generics. #14

fix(loupe-derive) Handle struct/enum with inlined generics. #14

Hywan commented Mar 23, 2021

fix(loupe-derive) Handle struct/enum with inlined generics. #14

fix(loupe-derive) Handle struct/enum with inlined generics. #14

Conversation

Hywan commented Mar 23, 2021