Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tls_certificate_check to 1.18.1 #642

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Jun 30, 2023

Feature or Problem

I used elixir 1.15 in my environment

elixir --version
Erlang/OTP 25 [erts-13.2.2.1] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit] [dtrace]

Elixir 1.15.0 (compiled with Erlang/OTP 25)

and when I use make build it fails due to deadtrickster/ssl_verify_fun.erl#27

$ make build
...
==> ssl_verify_fun
Compiling 7 files (.erl)
src/ssl_verify_fun_cert_helpers.erl:13:14: can't find include lib "public_key/include/public_key.hrl"
%   13| -include_lib("public_key/include/public_key.hrl").
%     |              ^

src/ssl_verify_fun_cert_helpers.erl:23:34: undefined macro 'id-ce-subjectAltName'
%   23|   AltSubject = select_extension(?'id-ce-subjectAltName', Extensions),
...

Although the latest version of tls_certificate_check is 1.19.0, it removed somethings that I wasn't sure were causing any problems, so I upgraded to 1.18.1, and from the release notes, it's safe

Built successfully in 1.14.5(OTP 25)

Related Issues

Release Information

Consumer Impact

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Unit Test(s)

Acceptance or Integration

Manual Verification

Copy link
Contributor

@connorsmith256 connorsmith256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you for the contribution @Iceber

@connorsmith256 connorsmith256 merged commit 1f276d0 into wasmCloud:main Jul 1, 2023
42 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants