correct key for provider link name in supp config during vhost autostarts #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihil2501
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
stevelr
as code owners
…arts Signed-off-by: Oren Mittman <[email protected]>
nihil2501
force-pushed
the
fix/autostart-provider-link-name-key
branch
from
eecee63
to
eaf53fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Typo in provider link name key of virtual host auto-starts config introduced here:
linkeName->linkNamePresumably this would fail to supply the configured link name to the auto-started provider.
Related Issues
Commented on in the original PR here
Release Information
nextConsumer Impact
No changes required from dependents.
Testing
Test suite did not exercise the code in question.
Built on platform(s):
Whatever
make testbuilds with docker.Tested on platform(s):
Untested
Manual Verification
None