Pass expected name for enabling structured logging in providers #558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Currently, the host passes
enable_structured_logging
as a field in theHostData
given to providers via stdin when they start. However, the smithy definition ofHostData
expects the field to be serialized asstructured_logging
.In effect, there is no way to enable structured logging in providers today, since we've misspelled the field.
Related Issues
This doesn't fix wasmCloud/weld#140, but it is related
Release Information
Next release
Consumer Impact
The impact should be positive, since we're enabling structured logs for providers, unifying the log format between the host and providers. However, on the off chance that users are relying on this buggy behavior today, this could technically be considered a breaking change(?)
Testing
Unit Test(s)
N/A
Acceptance or Integration
N/A
Manual Verification
WASMCLOUD_STRUCTURED_LOGGING_ENABLED=true WASMCLOUD_STRUCTURED_LOG_LEVEL=debug make run
{"timestamp":"2023-03-07T16:44:24.744883Z","level":"INFO","fields":{"message":"finished processing with success","status":200},"target":"warp::filters::trace"}