fix various bugs related to policy checks #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Smith <[email protected]>
connorsmith256
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
stevelr
as code owners
connorsmith256
commented
Jan 21, 2023
| contractId: target["contract_id"], | ||
| linkName: target["link_name"], | ||
| issuer: target_claims[:iss] | ||
| }, |
There was a problem hiding this comment.
These were mistakingly removed
connorsmith256
commented
Jan 22, 2023
| @@ -71,7 +72,7 @@ defmodule HostCore.Policy.Manager do | |||
| publicKey: host_config.host_key, | |||
| issuer: host_config.cluster_key, | |||
| latticeId: host_config.lattice_prefix, | |||
| labels: host_config.labels, | |||
| labels: labels, | |||
There was a problem hiding this comment.
host_config does not contain a :labels key, causing this to silently fail every time the function is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs that would prevent actors/providers from starting/invocations from being processed. I also refactored
start_actorto have significantly less nesting in an attempt to make it easier to read.I tested these changes by:
Everything seems to be working now
Signed-off-by: Connor Smith [email protected]