feat(*)!: Makes version optional #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes two major changes. The first, and most important, is that versions are now optional. If no version field is passed, wadm will automatically generate a ULID to use as its version. This means that listing versions can be done in order by sorting them lexographically. Second is an inversion of the delete behavior. Most of the time the delete endpoint in practice has been used to delete the whole application and not just a specific version. Now, by default, if you call the delete endpoint, it will delete all versions. You can still pass a now optional version to delete a single specific version. While I was in the handlers, I also removed an unused field for orphaning undeploys Signed-off-by: Taylor Thomas <[email protected]>
thomastaylor312
requested review from
autodidaddict,
brooksmtownsend and
connorsmith256
as code owners
lachieh
added a commit
to wasmCloud/wasmCloud
that referenced
this pull request
May 14, 2024
…ange see wasmCloud/wadm#281 Signed-off-by: Lachlan Heywood <[email protected]>
brooksmtownsend
requested changes
May 15, 2024
There was a problem hiding this comment.
Fully in support of making version optional, though I would request changing the commit to feat(*)! because not providing a version now is destructive instead of an error. On the wash-lib / wash-cli side we can still handle the --delete-all flag gracefully, and perhaps provide a warning, but it won't break existing functionality since not providing a version previously is an error
| @@ -312,10 +312,6 @@ impl<P: Publisher> Handler<P> { | |||
| .await | |||
| } | |||
|
|
|||
| // NOTE(thomastaylor312): This is different than wadm 0.3. I found it remarkably confusing that | |||
lachieh
added a commit
to wasmCloud/wasmCloud
that referenced
this pull request
May 15, 2024
…ange see wasmCloud/wadm#281 Signed-off-by: Lachlan Heywood <[email protected]>
thomastaylor312
changed the title
|
@brooksmtownsend I updated the PR and the commit message on the squash merge to have the |
brooksmtownsend
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two major changes. The first, and most important, is that versions are now optional. If no version field is passed, wadm will automatically generate a ULID to use as its version. This means that listing versions can be done in order by sorting them lexographically.
Second is an inversion of the delete behavior. Most of the time the delete endpoint in practice has been used to delete the whole application and not just a specific version. Now, by default, if you call the delete endpoint, it will delete all versions. You can still pass a now optional version to delete a single specific version.
While I was in the handlers, I also removed an unused field for orphaning undeploys