feat: support TLS CA certificates when building a NATS client #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NATS servers support TLS, which means sometimes you need to be able to provide certificates when instantiating a client. This specifically adds support for supplying a CA certificate to use when connecting to a NATS server. I opted not to add client certificate support for mTLS for now, but it's an easy lift if it should just be added now. Signed-off-by: Dan Norris <[email protected]>
protochron
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
connorsmith256
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
NATS servers support TLS, which means sometimes you need to be able to provide certificates when instantiating a client.
This specifically adds support for supplying a CA certificate to use when connecting to a NATS server. I opted not to add client certificate support for mTLS for now, but it's an easy lift if it should just be added now.
Related Issues
Release Information
Consumer Impact
Testing
Tested locally using a NATS server with a self-signed CA and cert. Everything worked fine
Unit Test(s)
Acceptance or Integration
Manual Verification