feat(events): support actor_scaled event #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
brooksmtownsend
force-pushed
the
feat/support-actor-scaled
branch
from
171f723
to
cd503bd
Compare
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
connorsmith256
previously approved these changes
Jan 16, 2024
thomastaylor312
requested changes
Jan 17, 2024
Signed-off-by: Brooks Townsend <[email protected]> add scaled events to parse Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/support-actor-scaled
branch
from
cd503bd
to
dd54476
Compare
thomastaylor312
approved these changes
Jan 24, 2024
|
Holding on the merge here just a moment to ensure we can release v0.82 before we start cutting wadm releases with this change. Only reason why is that here, for v0.82, we'll handle both the actorscaled and actorsstarted events so we might get incorrect state inbetween heartbeats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR adds a handler for the actor_scaled event which will be able to summarize all of the information in
actors_startedandactors_stoppedwith an idempotent event.Though there's future work to really make this work with v0.82, this can be released at any time without problems as the event doesn't exist yet.
Related Issues
Requires wasmCloud/wasmCloud#1336
Filed #239 to cover future work that can't be done today.
Release Information
v0.11.0
Consumer Impact
Note that, if testing with the unreleased v0.82.0, this may cause duplicate state updates because both the actors_started and actor_scaled events will be handled. I'll be creating an issue shortly to cover this update.
Testing
Unit Test(s)
I modified the
test_all_statefunction to ensure functionality around starting/stopping/scaling up/down actors.Acceptance or Integration
Manual Verification