fix(scaler): resolve possible linkdef loop #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
Signed-off-by: Brooks Townsend <[email protected]>
thomastaylor312
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR resolves a problematic infinite loop when it comes to link scalers. In rare cases it's possible for a link scaler to receive a
LinkdefSetevent for its own link definition, but when it goes to query the list of link definitions nothing comes back. This is an external problem to wadm, usually manifesting if a host fails to respond in time, but in this case the link scaler will publish a command to set the link definition and then will trigger aLinkdefSetevent ➿.This PR simply shortens this feedback loop to doing what is intended, when a link scaler receives the
LinkdefSetevent and it matches all of its configuration parameters, it updates its internal status toDeployed.Related Issues
This is a temporary patch, #206 should make this unnecessary but there's no harm in keeping this logic.
Release Information
v0.10.0
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification