chore: Replace atty with std::io::IsTerminal #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
connorsmith256
as code owners
Signed-off-by: Joonas Bergius <[email protected]>
joonas
force-pushed
the
joonas/replace-atty-with-stdlib
branch
from
615ad94
to
70f2752
Compare
|
|
thomastaylor312
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Yep, we've been doing this in other projects so it is about time we did it here. Thanks @joonas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
As best as I can tell,
attyis unmaintained, which is unfortunate because it has an outstanding security vulnerability (RUSTSEC-2021-0145 / GHSA-g98v-hv3f-hcfr).Fortunately, Rust 1.70.0 shipped native functionality to replace what
attywas providing.I might've missed it, since I don't believe we have a defined msrv, I think expecting Rust 1.70.0 for this functionality seems fair.
If this is a bad assumption or we absolutely insist on supporting Hermit, we should at least consider switching from
attytois-terminal, which is a drop-in replacement forattybut maintained.Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification