fix(scaler): remove backoff wrapper around link #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
thomastaylor312
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR removes the
BackoffAwareScalerwrapper around Actor and link scalers as it is not a useful addition to the scaler logic. Both actor and link scalers issue idempotent commands and actor scalers actually haven't utilized the backoff functionality since #171. In some cases we even see linkdef scalers looping infinitely so this should fix that.Related Issues
#171
Release Information
v0.9.2 with a cherry pick
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification