feat(status): prevent duplicate status publishes #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
feat/dedup-status-messages
branch
from
42a9135
to
a1ca726
Compare
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
connorsmith256
previously approved these changes
Nov 28, 2023
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/dedup-status-messages
branch
from
a1ca726
to
f3bb670
Compare
connorsmith256
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR adds a simple check before publishing a status to query the previous status and skip publishing if it would be the exact same. This should quiet down the status stream quite a bit for already deployed applications and it should make it a lot easier to follow during debugging.
Related Issues
Fixes #187
Release Information
nextrelease, can be a patch.Consumer Impact
This PR does add a burden on the status stream with a stream get
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
The status stream was much less noisy during e2e tests, for example during the upgrade e2e test the number of status messages went from 57 to 23. This is impressive as this PR isn't primarily concerned with reducing the number during deployment, we just end up publishing a lot of duplicate statuses.